plugin: don't try to pickle the exceptions thrown by blocking_activity#1814
Merged
Conversation
abderrahim
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
abderrahim
force-pushed
the
abderrahim/blocking-activity
branch
from
9fc9841 to
c26669c
Compare
Contributor
|
@abderrahim we could send exception class and args, then reconstruct exception on other side without stack trace. |
Contributor
|
But this is certainly an improvement already. |
While this is technically an API break, the old promise of raising the error in the calling process never worked.
Don't rely on the ability to get pickled exceptions from blocking_activity as that doesn't seem to work with any supported python version. May help with #1766
abderrahim
force-pushed
the
abderrahim/blocking-activity
branch
from
c26669c to
3778522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.